Repository navigation
Conversation
|
@echelon Could you review this anchor-alignment fix? The PR is ready for review. The full Linux + wasm quality gate passed for the exact PR commit GitHub does not allow this fork author to assign a reviewer, so I am requesting review here. |
|
Thank you for this @haranishi, and welcome! #1216 fixed #1180 the same way about ten minutes before this PR opened: Align moves only the selected anchors, to their bounds or to the artboard. So I'm closing this one as a duplicate. Sorry for the overlap. Your tests are thorough. If you find a case where main still aligns differently from yours (repeating a no-op alignment, for example), a follow-up PR with that test would be very welcome. Your compound-path follow-up (#1225) is being checked now. If you'd like to chat with the team, come say hi on Discord: https://discord.gg/artcraft |
|
Thanks for the suggestion. I reproduced the repeated no-op alignment case and submitted the regression test and fix in #1276, which is now merged. Repeating an alignment that does not move the selected anchors no longer adds an Undo step. The original anchor-alignment fix remains the one from #1216. |
What and why
Closes #1180.
Direct Selectionでパスの一部のアンカーを選んだとき、Alignがパス全体を移動する不具合を修正します。
M100 40 L200 60 L150 160 Zの上側2点を選んでVertical Align Centerを実行すると、選択点のYが50に揃い、3点目は(150, 160)に残ります。選択点の位置から整列範囲を求め、各アンカーとそのハンドルを移動します。Align to Artboardにも対応します。パスが1つでもアンカー選択中はAlignパネルの指定先を使います。変更は1回のUndoで戻り、同じ整列を繰り返してもUndo履歴を増やしません。
操作仕様は公開ドキュメントを参照しました。キーアンカーによる整列は引き続き未実装です。
How it was tested
(100, 50)・(200, 50)、未選択点は(150, 160)のまま。Undo/Redo後も座標を確認。cargo xtask ci:macOSで全7工程成功(fmt、clippy、5,332テスト成功・失敗0件・4件ignore、assets、brands、layers、wasm)。craft-fontsは指定せず、任意フォントが必要なテストは既存ルールに従ってスキップします。GitHub Actionsの全CIも同じコミットc98cfeecで成功しました。Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).Result.ASSETS.md(新しい資産の追加なし)。