Repository navigation
fix: 動かないアンカー整列でUndo履歴を増やさない #1180 - #1276
Merged
bflatastic merged 1 commit intoOct 12, 2026
Merged
Conversation
haranishi
marked this pull request as ready for review
October 11, 2026 21:18
Contributor
Author
|
@echelon @bflatastic レビューをお願いします。#1211でご案内いただいた、mainでも残っていた「動かないアンカー整列でUndo履歴を消費する」問題の追加修正です。修正前に失敗する2件の回帰テストを追加し、Redo・保存済み状態・リビジョン・ハンドル座標も保つようにしました。ネイティブアプリで文書・画素の一致と1回のUndo/Redoを確認済みです。macOSとLinux + wasmの全7工程、上流AffinityのCIも同一コミットで成功しました。 |
bflatastic
force-pushed
the
fix/issue-1180-align-noop-history
branch
from
October 12, 2026 00:48
ca793d7 to
4109717
Compare
Member
|
Thanks @haranishi! Merged. It's rebased onto current main with no changes of mine, and the full local gate passed. A repeated anchor Align no longer adds an undo step. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Refs #1180
整列済みのアンカーをもう一度整列すると、Undo履歴が増える問題を直します。1回のUndoで直前の整列を戻せず、Redoも消え、保存済み文書が変更済みになります。
メンテナーから案内された追加修正です。全アンカーの移動量が両軸とも既存のオブジェクト整列と同じ
1e-9 pt以内なら、編集を記録せず返します。実際に動く整列は1回のUndoで戻せます。関連資料のスコア・工数は据え置きました。How it was tested
cargo xtask ci: macOSの全7工程成功、5,383件成功・0件失敗・4件ignored。ui.screenshotはNoFrameで取得できず、OSの実マウス操作・パネル表示は未検証です。vectorcraft-cli perf --paths 50000: 修正前後とも全10項目が予算内。負荷警告が出たため、速度比較の根拠にはしていません。ca793d709a3870db0c31d5282b3ead61a0f1c539を指定した Linux + wasmの全CI と 上流Affinity 3 corpus が同一コミットで成功しました。Linux + wasmは全7工程、5,368件成功・0件失敗・4件ignoredです。Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).