Repository navigation
Move: clicking an axis arrow without dragging shows that axis in the value box (#13101) - #13167
Draft
dudedagger42 wants to merge 3 commits into
Draft
dudedagger42 wants to merge 3 commits into
dudedagger42 wants to merge 3 commits into
Conversation
…(#GABE) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ncy-labs#13101) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…abs#13101) gizmo::show reports nothing until a drag starts, so a press and release that arrive in one frame never reached dialogs_move::drag and the box stayed on X. Record a press on a handle that starts no drag, and show its value in the box; a click moves nothing. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Move, a click on the Y or Z arrow (or a ring in Free Move) that starts no drag left the canvas value box on X. Dragging an arrow already switched the box (#4776), but a press and release that arrive in one frame, as input queued while the window is busy does (#8265), never start a drag, so
dialogs_move::dragwas never called.gizmo::shownow records a press on a handle that starts no drag,gizmo::take_clickhands it out, and the Move canvas shows that handle's value with the same mappingdrag()uses (nowshow_handle_value). A click moves nothing. Dragging is unchanged.Changes a default: no
Fixes #13101
Tests: the first commits add
a_click_on_an_arrow_puts_the_box_on_its_axis(X, Y and Z arrows with the press and release in separate frames, and Y and Z in one frame; the one-frame cases fail on main with the box on X) andthe_box_reads_the_total_from_the_start(drags of +5 and +3 read 8 mm, typing 10 sets the total from the start; this already held and is pinned). The last commit is the fix. Rancargo test -p solidcraft-ui-egui --lib -- dialogs_move::tests(29 pass).🤖 Generated with Claude Code