Repository navigation
Fixes #39770 - display report for remediation plan leapp jobs - #181
Merged
Lukshio merged 1 commit intoSep 30, 2026
Merged
Conversation
adamruzicka
reviewed
Sep 22, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
While this is better, it still doesn't completely match how the backend (and the old, erb+deface based ui) does things.
A job template can be attached to a number of "remote execution features". The backend checks whether the job's template has a particular feature attached to it and displays the report based on that[1,2].
[1] -
foreman_leapp/lib/foreman_leapp/engine.rb
Line 32 in 2ac8813
[2] - https://github.com/theforeman/foreman_leapp/blob/master/app/lib/helpers/job_helper.rb#L8
andreilakatos
force-pushed
the
fixes-39770-remediation-plan-report
branch
from
September 22, 2026 13:25
45b9d28 to
691b027
Compare
adamruzicka
reviewed
Sep 22, 2026
andreilakatos
force-pushed
the
fixes-39770-remediation-plan-report
branch
from
September 23, 2026 12:35
691b027 to
211cbd3
Compare
adamruzicka
reviewed
Sep 23, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
Haven't tested, but looks reasonable at a glance
Contributor
|
@andreilakatos rubocop needs fix |
…play report for remediation plan leapp jobs
andreilakatos
force-pushed
the
fixes-39770-remediation-plan-report
branch
from
September 30, 2026 12:16
211cbd3 to
797ce2b
Compare
Contributor
|
packit tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39770 - display report for remediation plan leapp jobs
