Skip to content

fix(bugs): clamp page on empty client-side filter results - #335

Open
ayush-that wants to merge 1 commit into
usedetail:mainfrom
ayush-that:fix/clamp-page-empty-filter-paths
Open

fix(bugs): clamp page on empty client-side filter results#335
ayush-that wants to merge 1 commit into
usedetail:mainfrom
ayush-that:fix/clamp-page-empty-filter-paths

Conversation

@ayush-that

@ayush-that ayush-that commented Aug 20, 2026

Copy link
Copy Markdown

bugs list --vulns --page 5 on a repo with no vulns prints Page: 5 of 1.

The issue suggests clamping in both early-return branches. I dropped the returns instead: they only printed the empty-result hint, and the code just below already handles an empty set and clamps the page. Now reads Page: 1 of 1.

Closes #334.


Open in Devin Review

Summary by cubic

Clamps page number for empty client-side filter results in bugs list, fixing incorrect "Page: N of 1" output. Before: early returns printed the hint and returned "Page: 5 of 1"; now: print the hint (table only) and fall through to normal pagination, yielding "Page: 1 of 1".

  • Removes two early returns in empty-result branches; retains the empty-results hint for table output.
  • Delegates empty sets to output_list, which clamps the page.
  • No changes to non-table formats or non-empty results.

Written for commit 4b3aa46. Summary will update on new commits.

Review in cubic

Copilot AI lite review requested due to automatic review settings August 20, 2026 11:26
@aviator-app

aviator-app Bot commented Aug 20, 2026

Copy link
Copy Markdown

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Detail Bug] CLI: bugs list shows impossible page numbers on some client-side filtered empty results

2 participants