Skip to content

fix(bugs): clamp page on empty client-side filter results #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayush-that wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(bugs): clamp page on empty client-side filter results #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/commands/bugs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,22 +738,16 @@ pub async fn handle(command: &BugCommands, cli: &crate::Cli) -> Result<()> {
if !introduced_by.is_empty() {
let pre_filter = filtered;
filtered = filter_by_introduced_by(&pre_filter, introduced_by);
if filtered.is_empty() {
if matches!(format, crate::OutputFormat::Table) {
let hint = empty_filter_hint(&pre_filter, *vulns);
Term::stdout().write_line(&hint)?;
}
return output_list(&filtered, 0, *page, *limit, format);
if filtered.is_empty() && matches!(format, crate::OutputFormat::Table) {
let hint = empty_filter_hint(&pre_filter, *vulns);
Term::stdout().write_line(&hint)?;
}
} else if filtered.is_empty() {
} else if filtered.is_empty() && matches!(format, crate::OutputFormat::Table) {
// Filters (or `--all` against an empty repo) removed
// everything. Print the hint so the user gets context
// beyond an empty table.
if matches!(format, crate::OutputFormat::Table) {
let hint = empty_filter_hint(&filtered, *vulns);
Term::stdout().write_line(&hint)?;
}
return output_list(&filtered, 0, *page, *limit, format);
let hint = empty_filter_hint(&filtered, *vulns);
Term::stdout().write_line(&hint)?;
}
let total = filtered.len();
if *all {
Expand Down