Fixing all Examples#42
Merged
Merged
Conversation
rogeriojorge
requested changes
Jul 9, 2026
rogeriojorge
left a comment
rogeriojorge
left a comment
Member
There was a problem hiding this comment.
A couple of changes asked for
EstevaoMGomes
changed the title
…Tree traversal, fixing 'None is not a valid value for jnp.array' crash in tracing (from_simsopt and from_json paths)
Guard Coils.dofs_currents against None/bool sentinels (fixes tracing crash on #42)
Contributor
Author
|
The only example not working is with from_simsopt method. but I dopnt have a solution for this yet. I would merge this and solve that after. The change fo PR #43 works also on older diffrax version. @rogeriojorge @EstevaoMGomes |
rogeriojorge
requested changes
Jul 15, 2026
rogeriojorge
left a comment
rogeriojorge
left a comment
Member
There was a problem hiding this comment.
A couple of small things, and then it's ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request to clean examples and make them work with PR #36 to PR #40. Due to the new changed requesting during pull request some of them stopped working. So I had to add some changes to coils and surface classes to make them work again. There is however, still a problem with examples using stochastic optimization and the classifier object.