[robert3005]

VarBinViewData::new_unchecked ran a debug-only validation that executed the validity using legacy_session(). It is deleted. Callers of new_unchecked already promise valid parts, and the checked constructors still validate.

part of #9446

[codspeed]

Merging this PR will degrade performance by 0.93%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 16 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• test_scan_filter[int_float]
• test_scan_filter[int_str_float]
• test_scan_filter[int_str]
• test_repeated_scan_to_arrow_array[int_str]
• test_scan[int_str]
• random_i128[0.01]
• take_varbin
• test_scan[int_str_float]
• multipolygon_mixed_validity
• decompress[u16, (4000, 256)]
• …and 6 more

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

• test_scan_filter_to_arrow_array[int_float]
• test_repeated_scan_filter[int_float]
• test_repeated_scan_filter[int]
• test_scan_filter_to_arrow_array[int]
• test_scan_filter[int]
• test_repeated_scan_scalar_at[int_float]
• test_repeated_scan_scalar_at[int_str_float]
• test_scan_filter[int_float]
• test_scan_filter[int_str_float]
• test_scan_scalar_at[int_str]
• …and 30 more

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 4 regressed benchmarks
✅ 2401 untouched benchmarks
⏩ 12 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌ ℹ️	Simulation	test_scan_filter_to_arrow_array[int_float]	3.5 ms	4.1 ms	-13.68%
❌	Simulation	isolated_runs[u32, (16, 0)]	78.5 µs	88.4 µs	-11.21%
❌ ℹ️	Simulation	test_repeated_scan_filter[int_float]	3.4 ms	3.9 ms	-11.19%
❌ ℹ️	Simulation	test_repeated_scan_filter[int]	2.4 ms	2.7 ms	-10.65%
⚡	WallTime	bitpack_blocked_compress_avx512	5.6 µs	4.7 µs	+19.13%
⚡	WallTime	threshold_neon[80]	3.9 µs	3.4 µs	+16.6%
⚡	WallTime	mul_u16_nonnull_avx2	12.2 µs	11 µs	+10.85%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing rk/legacy-session-varbinview (5b51f4c) with develop (31e0724)}

Footnotes

1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩