Skip to content

Drop VarBinView's debug validation in new_unchecked #10584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 2 commits into from
Oct 20, 2026
+0 −15
Merged

Drop VarBinView's debug validation in new_unchecked #10584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eb80af
Skip executing validity in VarBinView debug validation
claude Oct 18, 2026
5b51f4c
Drop VarBinView's debug validation in new_unchecked
claude Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions vortex-array/src/arrays/varbinview/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ use vortex_mask::Mask;
use crate::ArrayRef;
use crate::ArraySlots;
use crate::ExecutionCtx;
#[cfg(debug_assertions)]
use crate::VortexSessionExecute;
use crate::array::Array;
use crate::array::ArrayParts;
use crate::array::TypedArrayRef;
Expand All @@ -40,8 +38,6 @@ use crate::builders::ArrayBuilder;
use crate::builders::VarBinViewBuilder;
use crate::dtype::DType;
use crate::dtype::Nullability;
#[cfg(debug_assertions)]
use crate::legacy_session;
use crate::validity::Validity;

#[array_slots(VarBinView)]
Expand Down Expand Up @@ -312,17 +308,6 @@ impl VarBinViewData {
dtype: DType,
validity: Validity,
) -> Self {
#[cfg(debug_assertions)]
#[expect(clippy::disallowed_methods)]
Self::validate(
&views,
&buffers,
&dtype,
&validity,
&mut legacy_session().create_execution_ctx(),
)
.vortex_expect("[Debug Assertion]: Invalid `VarBinViewArray` parameters");

let handles: Vec<BufferHandle> = buffers
.iter()
.cloned()
Expand Down
Loading