Repository navigation
Conversation
middelkoopt
self-requested a review
December 5, 2025 18:38
Contributor
|
Looking good, I'll need to work on 10.1 and 9.7 updates and am traveling, in the mean time can you please add yourself to the contributors file and add a "sign-off" to the commit. Thanks. |
Contributor
|
I included this with #92 with you as co-author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for Issue #90
dhclientis deprecated as of 2022 according to the ISCNetworkManagerprovides it's own dhcp clientAny container that has
NetworkManagerdoes not needdhclientinstalled.Tested on a Rocky 9 Container. The Warewulf Server was able to deploy the container onto a node and assign an IP address.