[damster101]

No description provided.

[waruqi]

Why? It doesn't seem to have any impact; besides, the build cache for cl is currently disabled by default.

[damster101]

Why? It doesn't seem to have any impact; besides, the build cache for cl is currently disabled by default.

When targeting wasm I got this warning on every compilation:

clang: warning: argument unused during compilation: '-c' [-Wunused-command-line-argument]

The emcc toolchain inherits from gcc.lua, so unlike native Clang, it does not inject -Qunused-arguments.
Since emcc uses Clang, _preprocess passes -c alongside -E, and without -Qunused-arguments, triggering the false warning, which is then captured by build_cache and reprinted on every compilation.

Filtering out -c when adding -E in _preprocess prevents the preprocessor from receiving the unused compile flag.

I changed cl.lua as well because clang-cl inherits from it... but since MSVC cl build cache is disabled by default, it indeed doesn't do anything. I'm completely fine with removing that change.

[waruqi]

Why? It doesn't seem to have any impact; besides, the build cache for cl is currently disabled by default.

When targeting wasm I got this warning on every compilation:

clang: warning: argument unused during compilation: '-c' [-Wunused-command-line-argument]

The emcc toolchain inherits from gcc.lua, so unlike native Clang, it does not inject -Qunused-arguments. Since emcc uses Clang, _preprocess passes -c alongside -E, and without -Qunused-arguments, triggering the false warning, which is then captured by build_cache and reprinted on every compilation.

Filtering out -c when adding -E in _preprocess prevents the preprocessor from receiving the unused compile flag.

I changed cl.lua as well because clang-cl inherits from it... but since MSVC cl build cache is disabled by default, it indeed doesn't do anything. I'm completely fine with removing that change.

if emcc use clang, you can modify emcc.lua to inherit clang.

[waruqi]

Now emcc has inherited clang, I think we need not add this patch. -Qunused-arguments flag has been added.