Skip to content

do not pass -c to preprocessor in build_cache #7867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damster101 wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −3
Open

do not pass -c to preprocessor in build_cache #7867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xmake/modules/core/tools/emcc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
-- @file emcc.lua
--

-- inherit gcc
inherit("gcc")
-- inherit clang
inherit("clang")

-- make the optimize flag
--
Expand Down
4 changes: 3 additions & 1 deletion xmake/modules/core/tools/gcc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ function _preprocess(program, argv, opt)
end

-- get preprocessor flags
table.insert(cppflags, flag)
if flag ~= "-c" then

@waruqi waruqi Oct 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now emcc has inherited clang, I think we need not add this patch. -Qunused-arguments flag has been added.

table.insert(cppflags, flag)
end

-- for c++ modules, we cannot support it for clang now
if is_clang and flag:startswith("-fmodules") then
Expand Down
Loading