Skip to content

feat(docker): add ArduPilot and Gazebo environment variables - #50

Merged
yeseorizi merged 2 commits into
IOES-Lab:ros2from
sirinesioud-hash:feature/ardupilot-gz-env-vars
Sep 4, 2026
Merged

feat(docker): add ArduPilot and Gazebo environment variables#50
yeseorizi merged 2 commits into
IOES-Lab:ros2from
sirinesioud-hash:feature/ardupilot-gz-env-vars

Conversation

@sirinesioud-hash

@sirinesioud-hash sirinesioud-hash commented Aug 12, 2026

Copy link
Copy Markdown

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@yeseorizi

Copy link
Copy Markdown
Collaborator

Maintainer follow-up applied in 0659ea6:

  • kept ArduSub and Gazebo paths available to non-interactive container commands;
  • removed the duplicate root shell startup hook;
  • removed undefined GZ_SIM_* self-references and trailing empty path entries.

Validation: the Docker harness resolved both ardusub and sim_vehicle.py in interactive and non-interactive shells, with each PATH / Gazebo entry present exactly once. Repository pre-commit checks pass.

@yeseorizi
yeseorizi merged commit 36f0c5a into IOES-Lab:ros2 Sep 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants