Set explicit ArduSub simulation speedup - #55
Open
yeseorizi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass an explicit
--speedup 1argument when DAVE starts ArduSub for all three BlueROV2 configurations.Problem
In the tested ARM64 SITL build, starting
ardusubwithout an explicit speedup leftSIM_SPEEDUPat-1. After Gazebo JSON sensor input started, ArduSub terminated withSIGFPEinAP_Logger_File::periodic_1Hz().GDB placed the exception in the logger path. The relevant ArduPilot code multiplies an unsigned timeout by the SITL speedup value, so the negative default creates an invalid boundary in this environment.
Change
Add the explicit real-time speed factor to the existing ArduSub command:
The change is applied consistently to:
bluerov2bluerov2_heavybluerov2_heavy_multibeam_sonarNo vehicle parameters, controller settings, or bridge interfaces are changed.
Reproduction
Launch any of the BlueROV2 variants with ArduSub enabled and wait for the Gazebo JSON connection:
The reproduced baseline received JSON sensor data and then raised
SIGFPEin the ArduSub logger.Validation
The candidate was installed into the DAVE ARM64 Docker environment with ROS 2 Lyrical and Gazebo Jetty. Each BlueROV2 variant completed one bounded headless control run:
bluerov2bluerov2_heavybluerov2_heavy_multibeam_sonarThese results establish the simulated JSON/MAVROS/control connection in the tested environment. They do not establish controller tuning, physical safety, or real-vehicle accuracy.
Repository checks:
Checklist