Repository navigation
Conversation
# Conflicts: # iOSClient/HostSettingsPanel.swift # iOSClient/PortraitStreamScreen.swift # iOSClient/StreamScreen.swift
…does (Saffsanity#178) With Trackpad mode on, the trackpad lies over the picture, so the card's direct-touch rows (tap and hold where you touch, drag to scroll, the Pencil, and the pinch main added with Saffsanity#196) were wrong there. TourFeatures.trackpadMode picks 'The Picture Is a Trackpad': drag to move the pointer, tap to click, two fingers to right-click and to scroll, hold then drag, and the swipe row as before. tour: 732,453 checks, 129 of 129 mutants (3 new; one pattern made unique).
…picture, and starts it unzoomed (Saffsanity#178) The trackpad overlay had no recognizer for scroll or hover events, which go to the topmost view, so over the picture the iPad's trackpad or mouse (and a Mac's, with the iPad app on a Mac) scrolled nothing and the Mac's pointer stopped following it: TrackpadSurface lets both fall through to the picture's input view. A zoom made before Trackpad mode could not be pinched back (the trackpad takes two fingers): a change of mode gives back the whole picture. The tour's DEBUG line names Trackpad mode.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178.
What it does
TouchMode(Direct TouchvsTrackpad, saved inSill.touchMode, defaultDirect Touch) toPointerPresence.swiftand Settings › This iPad / This iPhone.TrackpadViewon the stream picture pane and enables the virtual cursor sprite (TouchMode.showsPointer(isPortrait:mode:)) in both landscape and portrait so dragging anywhere on the picture moves the pointer relatively, tapping clicks at the pointer, pressing and holding drags, and two fingers scroll.TourFeatures.trackpadMode): in Trackpad mode it is "The Picture Is a Trackpad" (drag to move the pointer, tap to click, two fingers to right-click and to scroll, hold then drag, and the three-finger swipe row as before), without direct touch's rows.TrackpadSurface.point(inside:with:)).Known
Why
Checks
InputOverlay, then the Trackpad overlay).Tests/checks/tour: 732,453 checks, 129 of 129 mutants (6 checks and 3 mutants new);run-all.sh: all 63.Tests/checks/pointer-presence: 171 checks, 0 failed; 46 of 46 mutants caught (3 new).Sill.xcodeproj) clean.What I tried
Not tested