Skip to content

[stack] feat(mail): restyle the email template and support dark mode - #65194

Merged
skjnldsv merged 1 commit into
masterfrom
feature/mail-template-restyle
Oct 7, 2026
Merged

skjnldsv merged 1 commit into
masterfrom
feature/mail-template-restyle

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Builds on #65193. Gives emails a fresh look: one card, the theme color as a header, bigger buttons, and dark mode where the mail client supports it (Gmail does its own thing). Button links are now escaped too.

Before After (light) After (dark) Mobile
Welcome mail before-new-account-email-light-700 new-account-email-light-700 new-account-email-dark-700 new-account-email-light-375
New blocks before-blocks-email-light-700 blocks-email-light-700 blocks-email-dark-700 blocks-email-light-375

Screenshots are browser renders of the test fixtures, not checked in Outlook or Gmail yet.

TODO

  • Check in Outlook desktop, Gmail web and Thunderbird

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests are included
  • Screenshots before/after for front-end changes
  • Documentation has been updated or is not required
  • Backports requested where applicable
  • Labels added where applicable
  • Milestone added for target branch/version

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv added this to the Nextcloud 36 milestone Oct 6, 2026
@skjnldsv skjnldsv self-assigned this Oct 6, 2026
@skjnldsv
skjnldsv added this pull request to stack #65196 October 6, 2026 14:56
@skjnldsv skjnldsv changed the title feat(mail): restyle the email template and support dark mode [stack] feat(mail): restyle the email template and support dark mode Oct 6, 2026
@skjnldsv
skjnldsv force-pushed the feature/mail-template-restyle branch from 5c4ffc2 to 9e9215c Compare October 6, 2026 14:58

@CarlSchwan CarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@skjnldsv
skjnldsv requested a review from a team as a code owner October 6, 2026 18:35
@skjnldsv skjnldsv removed the 2. developing Work in progress label Oct 6, 2026
@skjnldsv
skjnldsv requested review from Altahrim, come-nc, leftybournes and provokateurin and removed request for a team October 6, 2026 18:35
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Oct 6, 2026
Base automatically changed from feature/mail-template-blocks to master October 6, 2026 20:27
Puts the whole email in a rounded card with the theming color as a
header band, left aligned content, bigger buttons and a separated
footer. Colors are set inline for light mode and overridden through
prefers-color-scheme for clients that support it.

Button URLs are now escaped, and headings and the sender block close
an open body since they are card rows of their own.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv force-pushed the feature/mail-template-restyle branch from 48bcbaa to c09aac6 Compare October 6, 2026 20:27
@skjnldsv
skjnldsv merged commit df067a6 into master Oct 7, 2026
155 checks passed
@skjnldsv
skjnldsv deleted the feature/mail-template-restyle branch October 7, 2026 08:25

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :) Only thing I was wondering about is the duplication of the name, but that’s for a follow-up.

@skjnldsv

skjnldsv commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

that’s for a follow-up

Yes, I figured a call with the design team would be warranted. As those PRs are quite big, let's merge them and fine tune later ? :)

@skjnldsv

skjnldsv commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

@jancborchardt feel free to review the other from the stack. I added a lot of screenshots!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants