feat: integrate Data Tables, Tools, MCP, and Knowledge improvements - #468
Merged
Conversation
- embedding.py: configurable litellm_embedding_timeout (default 600s) passed as request_timeout; Ollama 400 single retry; batch_size=1 for ollama/ models - knowledge_source.py: test_connection whitelist API (tests pgvector + embedding) - knowledge_source.py: _warn_if_embedding_changed() warning when provider/model changes on a source with existing chunks - knowledge_source.js: Test Connection button handler with results dialog - knowledge_source.json: Test Connection button field (pgvector only) - knowledge_input.json: file field description updated to mention litellm_embedding_timeout
…sw params, distance_metric fix)
…+ backend contract doc
Add get_table_agent_access / set_table_agent_access to huf/huf/doctype/huf_data_table/api.py: from a HUF Table, scaffold deterministic Agent Tool Function docs (view -> Get List + Get Document, create/edit/delete -> Create/Update/Delete Document), attach/detach them on an agent's agent_tool child table idempotently, and report which agents have access. Tool docs are reused by deterministic name and never deleted on uncheck. params/function_definition are left to the Agent Tool Function controller's auto-generation. Adds IntegrationTestCase suite (8 tests) covering scaffolding shape, idempotency, detach semantics, get/set round-trip, partial-view state, and the flows.manage capability guard.
Create/Update/Get List tools scaffolded via set_table_agent_access now get Agent Function Params rows built from the table's DocType meta, so the generated function_definition exposes the real fields (previously Create had empty properties with additionalProperties: false). Re-running refreshes parameters compare-then-save; layout/hidden/read-only fields are excluded; reqd maps to required only on Create tools.
Add TableAgentAccessModal (agent picker + View/Create/Edit/Delete checkboxes) wired to the huf_data_table agent-access endpoints, entry points on the data list page and table view kebab, and a bulk-fetched "N agents" badge on table cards (2 REST calls, no N+1).
…ndly modal error
BUG-1: the 'N agents' badge could never render — the frontend computed
counts by REST-listing the Agent Tool child table, and Frappe strips all
fields from child-table rows queried without a parent context, so the
grouping always yielded {}. Add get_tables_agent_counts() (flows.use),
reusing _compute_access so distinct agents are counted server-side in one
call, and point the frontend at it. The dead child-table REST code (and
the doctype map entry it needed) is removed.
BUG-2: the access modal's error state showed raw JS error text. It now
shows a friendly message and logs the technical detail to the console.
Also replaces two pre-existing 'as any' filter casts in dataTableApi.ts
with an explicit getDocList filter type so the touched file is
eslint-clean.
This was referenced Jul 26, 2026
feat: tabs/sections/columns form layout for data tables, mirroring Frappe's own DocType builder
#457
Closed
esafwan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Final integration gate for the approved consolidation work before
develop.Included umbrella PRs
Chronological merge order
Original PR mapping
The umbrella descriptions contain the complete source-PR mapping and feature summary. The original implementation PRs were closed after their changes were represented in #460–#467.
Validation
git diff --checkpassed.tscis not installed in the checkout.integration/huf-consolidation-2026-07before merging this PR intodevelop.