Support remote project rules through repo metadata standing results by moirahuang · Pull Request #11460 · warpdotdev/warp

moirahuang · 2026-05-21T01:10:06Z

Description

Extend project-rule support to remote sessions while using the same discovery, cache, and lookup flow as local sessions.
Read local and remote WARP.md / AGENTS.md paths from RepoMetadataModel standing-query results. ProjectContextModel listens for repository and standing-result changes, then updates its shared path_to_rules cache for either a local repository or a host-qualified remote repository.
Keep file I/O at the app boundary: the app-provided read_project_rule_contents function reads local files with async_fs and remote files through RemoteServerManager. ProjectContextModel owns refresh ordering and reconciliation, including per-repository generation checks so an older asynchronous read cannot overwrite a newer refresh.
Preserve LocalOrRemotePath throughout rule lookup, agent context, and the Rules UI so identical remote paths on different hosts remain distinct. Global rules and persisted rule records remain local-only.
Existing behavior preserved: Manually adding any workspace explicitly requests its initial project-rule indexing before WorkspaceAdded is emitted. If the workspace is a standalone folder that is not already tracked, that indexing call first registers it with RepoMetadataModel; an already-detected repository skips registration but still receives the explicit initial refresh.
New behavior in this PR: Initial hydration now discovers rule paths from RepoMetadataModel standing-query results and uses the same shared ProjectContextModel refresh path as later metadata events. Subsequent rule changes refresh from metadata events for both local and remote repositories.
Remove the separate remote-rule reconciliation model. Also remove lookup helpers that silently treated Path values as local and replace the stored optional Arc<dyn Fn> reader with a stateless function pointer passed to refresh operations.

Linked Issue

No issue

Testing

./script/format
cargo check -p ai -p warp --all-targets
cargo nextest run -p ai project_context::model::tests — 28 passed
cargo nextest run -p warp ai::metadata_project_rules::tests — 3 passed
cargo nextest run -p warp ai::blocklist::context_model::tests — 11 passed
cargo clippy -p ai -p warp --all-targets -- -D warnings
git diff --check
I have manually tested my changes locally with ./script/run

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: Remote sessions now discover and apply project rules such as WARP.md and AGENTS.md.

Co-Authored-By: Oz oz-agent@warp.dev

moirahuang · 2026-05-21T01:10:19Z

Separate project-context discovery from display-only repository browsing #11921
Support remote project rules through repo metadata standing results #11460 👈 (View in Graphite)
Create standing results to track project skills and project rules #12047 : 1 other dependent PR (#12051 )
Add max result limit to get_repo_contents #12035
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Co-Authored-By: Oz <oz-agent@warp.dev>

moirahuang · 2026-06-04T22:37:52Z

+
+use crate::remote_server::manager::RemoteServerManager;
+
+pub(crate) fn read_project_rule_contents(


aka ProjectRuleContentReader

moirahuang · 2026-06-04T22:38:05Z

+/// App-provided transport for reading the exact rule paths discovered by repository metadata.
+///
+/// This remains injected because remote file reads are implemented in the app crate.
+pub type ProjectRuleContentReader = fn(


aka read_project_rule_contents which is used to read the actual project rule contents

moirahuang · 2026-06-04T22:39:58Z

-            .get(&project_root)
-            .cloned()
-            .unwrap_or_default();
+        let rule_paths = standing_project_rule_paths(


converts standing query results into local or remote values

moirahuang · 2026-06-04T22:56:36Z

-        } else {
-            None
-        };
+        let project_rules = current_working_directory_location


we're already typed, that simplifies this logic here

moirahuang · 2026-06-04T22:58:56Z

                        ProjectRule {
-                            path: file_path.clone(),
+                            // Global rule sources are watched under the local home directory.
+                            path: LocalOrRemotePath::Local(file_path.clone()),


purposefully keeping local

moirahuang · 2026-06-04T23:05:39Z

+    }
+
+    #[cfg(feature = "local_fs")]
+    fn apply_project_rules(


this is pulling out the logic from the original callsite

kevinyang372 · 2026-06-05T00:44:20Z

                },
            );
+
+            let remote_repo_ids = RepoMetadataModel::as_ref(ctx)


Will we even have any remote repos on app startup (this is called on initialize_app yeah?)

Usually there will not be remote repos on a cold startup, but RepoMetadataModel is registered before ProjectContextModel, and a remote snapshot can arrive before ProjectContextModel subscribes to metadata events. Refreshing already-tracked remote IDs closes that race and hydrates any preexisting snapshots. I added a comment explaining this.

^added this comment

cla-bot Bot added the cla-signed label May 21, 2026

moirahuang mentioned this pull request May 21, 2026

[1/5] Support remote project skills #11459

Merged

4 tasks

moirahuang force-pushed the moira/skills branch 2 times, most recently from 7038a4a to 1ba7f81 Compare May 21, 2026 18:56

moirahuang changed the base branch from moira/skills to graphite-base/11460 May 22, 2026 23:45

This was referenced May 22, 2026

[4/5] Use remote-aware skill locations in UI consumers #11581

Merged

Move local and remote project skills to use RepoMetadataModel #11559

Merged

moirahuang force-pushed the graphite-base/11460 branch from 1ba7f81 to a2f59d3 Compare May 23, 2026 00:39

moirahuang force-pushed the moira/remote-project-rules branch from c6a0eaa to c880386 Compare May 23, 2026 00:39

moirahuang changed the base branch from graphite-base/11460 to moira/skills May 23, 2026 00:39

moirahuang force-pushed the moira/remote-project-rules branch from c880386 to c4e9f90 Compare May 27, 2026 18:46

moirahuang changed the base branch from moira/skills to master May 27, 2026 18:46

moirahuang changed the base branch from master to graphite-base/11460 May 29, 2026 00:27

This was referenced May 29, 2026

[2/5] Preserve skill location identity through API references #11861

Merged

[3/5] Hydrate remote project skills #11862

Merged

[5/5] Resolve remote skill locations in tool output #11863

Merged

moirahuang force-pushed the moira/remote-project-rules branch from c4e9f90 to eae0db2 Compare May 29, 2026 19:56

moirahuang changed the base branch from graphite-base/11460 to moira/skills-ui-output-locations May 29, 2026 19:56

moirahuang force-pushed the moira/skills-ui-output-locations branch from 5e6b798 to 477221e Compare May 29, 2026 23:17

moirahuang force-pushed the moira/remote-project-rules branch 2 times, most recently from d4b8589 to 8f15075 Compare May 29, 2026 23:59

moirahuang force-pushed the moira/skills-ui-output-locations branch 3 times, most recently from 556a682 to 085de16 Compare May 30, 2026 01:24

moirahuang force-pushed the moira/remote-project-rules branch from 8f15075 to b70ba1c Compare May 30, 2026 01:24

moirahuang force-pushed the moira/skills-ui-output-locations branch from 085de16 to 356c1d5 Compare May 30, 2026 01:50

graphite-app Bot changed the base branch from moira/skills-ui-output-locations to graphite-base/11460 May 30, 2026 01:50

moirahuang force-pushed the moira/remote-project-rules branch from b70ba1c to 5969b7d Compare May 30, 2026 02:00

moirahuang changed the title ~~Support remote project rules~~ Unify local and remote project rule discovery May 30, 2026

moirahuang mentioned this pull request Jun 2, 2026

Support remote symlinked project skills #12051

Merged

2 tasks

moirahuang force-pushed the moira/remote-project-rules branch from 5a3fa42 to ffe55c1 Compare June 3, 2026 03:05

moirahuang changed the base branch from graphite-base/11460 to moira/remote-project-skill-symlinks June 3, 2026 03:05

moirahuang force-pushed the moira/remote-project-rules branch from ffe55c1 to 969dfcf Compare June 3, 2026 04:56

moirahuang changed the title ~~Remote project rules~~ Support remote project rules through repo metadata standing results Jun 3, 2026

moirahuang force-pushed the moira/remote-project-skill-symlinks branch from 87fc220 to abc3a4b Compare June 3, 2026 22:26

moirahuang force-pushed the moira/remote-project-rules branch from 969dfcf to 617b784 Compare June 3, 2026 22:26

moirahuang force-pushed the moira/remote-project-skill-symlinks branch from abc3a4b to 7f2c34d Compare June 3, 2026 22:36

moirahuang force-pushed the moira/remote-project-rules branch from 617b784 to cee7204 Compare June 3, 2026 22:36

moirahuang force-pushed the moira/remote-project-skill-symlinks branch from 8da6468 to b4f0407 Compare June 4, 2026 04:02

graphite-app Bot changed the base branch from moira/remote-project-skill-symlinks to graphite-base/11460 June 4, 2026 04:30

moirahuang force-pushed the moira/remote-project-rules branch from cee7204 to d51751f Compare June 4, 2026 22:03

moirahuang and others added 2 commits June 4, 2026 15:05

Unify local and remote project rule discovery

706ca0e

Co-Authored-By: Oz <oz-agent@warp.dev>

format name

1862fbe

Co-Authored-By: Oz <oz-agent@warp.dev>

moirahuang force-pushed the graphite-base/11460 branch from b4f0407 to 3fe0616 Compare June 4, 2026 22:07

moirahuang force-pushed the moira/remote-project-rules branch from d51751f to 38aa924 Compare June 4, 2026 22:07

moirahuang changed the base branch from graphite-base/11460 to master June 4, 2026 22:07

moirahuang removed the request for review from kevinyang372 June 4, 2026 22:08

Simplify project rule hydration

34f37c3

Co-Authored-By: Oz <oz-agent@warp.dev>

moirahuang force-pushed the moira/remote-project-rules branch from 38aa924 to 34f37c3 Compare June 4, 2026 22:40

moirahuang commented Jun 4, 2026

View reviewed changes

moirahuang requested a review from kevinyang372 June 4, 2026 23:03

moirahuang commented Jun 4, 2026

View reviewed changes

wasm

df81fb4

kevinyang372 approved these changes Jun 5, 2026

View reviewed changes

moirahuang added 2 commits June 4, 2026 22:32

clarifying comments

1d7b89b

clippy wasm

a952f94

moirahuang merged commit 8e1b7e9 into master Jun 5, 2026
26 checks passed

moirahuang deleted the moira/remote-project-rules branch June 5, 2026 06:07


		use crate::remote_server::manager::RemoteServerManager;

		pub(crate) fn read_project_rule_contents(

Conversation

moirahuang commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Testing

Agent Mode

Uh oh!

moirahuang commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

moirahuang commented May 21, 2026 •

edited

Loading

moirahuang commented May 21, 2026 •

edited

Loading