Skip to content

[5/5] Resolve remote skill locations in tool output#11863

Merged
moirahuang merged 4 commits into
masterfrom
moira/skills-ui-output-locations
May 31, 2026
Merged

[5/5] Resolve remote skill locations in tool output#11863
moirahuang merged 4 commits into
masterfrom
moira/skills-ui-output-locations

Conversation

@moirahuang
Copy link
Copy Markdown
Contributor

@moirahuang moirahuang commented May 29, 2026

Description

PR 5/5 of the remote-aware skills stack.

Resolve read/search result locations through the active session before mapping results back to known skills, preserving remote host identity in rendered output. This layer also removes the superseded local-only output helper and its tests.

Plan: https://staging.warp.dev/drive/notebook/EAngN0Hb9BqY5WiPMTXFV5
Agent run: https://staging.warp.dev/conversation/88702634-8ffe-46a4-b868-1efae92630eb

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • cargo fmt --manifest-path Cargo.toml -p warp_util -p ai -p warp

  • cargo test -p warp test_unique_skills --lib

  • cargo test -p warp parsed_skill_for_common_locations --lib

  • Full workspace clippy was started on the cumulative stack tip but not completed before submission.

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Co-Authored-By: Oz oz-agent@warp.dev

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 29, 2026

@moirahuang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates AI block output rendering so read-files and search-codebase tool outputs resolve skill buttons from session-aware local or remote locations. I did not find security findings or material spec drift; the attached spec context says no approved repository spec was found.

Concerns

  • This is a user-visible behavior change to tool output, but the PR description does not include screenshots or a screen recording. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@moirahuang moirahuang changed the title Resolve remote skill locations in tool output [5/5] Resolve remote skill locations in tool output May 29, 2026
@moirahuang moirahuang requested a review from kevinyang372 May 29, 2026 00:45
@moirahuang moirahuang force-pushed the moira/skills-ui-consumers branch from 278c688 to 5f6fa32 Compare May 29, 2026 19:56
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch from befa271 to 5e6b798 Compare May 29, 2026 19:56
@moirahuang moirahuang force-pushed the moira/skills-ui-consumers branch 2 times, most recently from 8b5d0c1 to 783e4a5 Compare May 29, 2026 23:17
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch from 5e6b798 to 477221e Compare May 29, 2026 23:17
@moirahuang moirahuang force-pushed the moira/skills-ui-consumers branch from 783e4a5 to f7c7e76 Compare May 29, 2026 23:59
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch from 477221e to 63bfd99 Compare May 29, 2026 23:59
@moirahuang moirahuang changed the base branch from moira/skills-ui-consumers to graphite-base/11863 May 30, 2026 00:35
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch from 63bfd99 to 556a682 Compare May 30, 2026 01:23
@moirahuang moirahuang force-pushed the graphite-base/11863 branch from f7c7e76 to 74d2566 Compare May 30, 2026 01:23
@graphite-app graphite-app Bot changed the base branch from graphite-base/11863 to master May 30, 2026 01:24
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch 3 times, most recently from 356c1d5 to b7ca2b3 Compare May 30, 2026 01:50
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 30, 2026

Merge activity

  • May 30, 1:51 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • May 31, 5:59 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • May 31, 5:59 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • May 31, 7:36 AM UTC: @moirahuang merged this pull request with Graphite.

@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch from b7ca2b3 to f6b5f12 Compare May 31, 2026 05:58
Co-Authored-By: Oz <oz-agent@warp.dev>
moirahuang and others added 2 commits May 30, 2026 23:33
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
@moirahuang moirahuang merged commit debe6d8 into master May 31, 2026
26 checks passed
@moirahuang moirahuang deleted the moira/skills-ui-output-locations branch May 31, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants