[1/5] Support remote project skills#11459
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| return; | ||
| }; | ||
| let repo_metadata = RepoMetadataModel::as_ref(ctx); | ||
| let skill_paths = find_skill_files_in_tree(repo_id, repo_metadata, ctx); |
There was a problem hiding this comment.
lmk if this approach makes sense to get the remote skills scan_remote_repository_for_skills -> find_skill_files_in_tree -> spawn_read_remote_skills
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR threads LocalOrRemotePath through skill discovery/invocation and adds remote project skill hydration from remote repo metadata.
Concerns
- Remote project skills are only scanned on the initial remote repository update; later remote file-tree updates and repository removals are ignored, so the skill cache can become stale.
- Remote skill hydration reads every discovered remote
SKILL.mdwithout a cumulative batch limit.
Security
- The remote skill-content read has no cumulative byte budget, allowing a repository with many large skill files to drive unbounded network and memory work during metadata updates.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
moirahuang
changed the base branch from
graphite-base/11459
to
moira/skills-acquisition-repometadata
moirahuang
force-pushed
the
moira/skills-acquisition-repometadata
branch
from
565ce4b to
809eb44
Compare
moirahuang
changed the title
moirahuang
changed the title
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR rewires skill identity to carry LocalOrRemotePath through skill management, API conversion, and related action/UI paths so remote project skills can remain distinguishable by host.
Concerns
- This changes user-facing skill discovery, invocation, and open-skill flows, but the PR description does not include screenshots or a screen recording demonstrating the behavior end to end. Please attach visual evidence for the local and remote skill UI path before merging.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
2 participants
Description
PR 1/5 of the remote-aware skills stack.
This PR is largely just rewiring to represent skill identity using
LocalOrRemotePaththrough common skill management logic so remote skills remain distinguishable by host, while retaining local/remote branching only at concrete boundaries. This layer also consolidates task message conversion context to avoid expanding task update call signatures.Plan: https://staging.warp.dev/drive/notebook/EAngN0Hb9BqY5WiPMTXFV5
Agent run: https://staging.warp.dev/conversation/88702634-8ffe-46a4-b868-1efae92630eb
Linked Issue
ready-to-specorready-to-implement.Testing
cargo fmt --manifest-path Cargo.toml -p warp_util -p ai -p warpcargo test -p warp active_skill_by_reference --libFull workspace clippy was started on the cumulative stack tip but not completed before submission.
I have manually tested my changes locally with
./script/runAgent Mode
Co-Authored-By: Oz oz-agent@warp.dev