Supervise controlled-session lifecycle by omry · Pull Request #30 · omry/reploy

omry · 2026-08-08T21:46:32Z

Stack created with Sapling. Best reviewed with ReviewStack.

omry · 2026-08-08T21:47:40Z

Copilot

Pull request overview

Implements a host-owned controlled-session supervisor that orchestrates controller/workload startup, request handling, termination, output finalization, result delivery/ack, and cleanup, aligning the Docker runtime adapter with supervised lifecycle ownership.

Changes:

Add RunControlledSessionV1 and supporting supervisor implementation to drive the controlled-session lifecycle machine end-to-end.
Harden Docker workload PTY handling by switching lifecycle operations to container-ID targeting and adding explicit Started()/Cleanup() semantics.
Extend the lifecycle machine to represent startup failures where workload output finalization is still pending, plus add unit + Docker integration evidence and update design docs.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
internal/dockerdeploy/testdata/session_channel_helper/main.go	Adds a “supervise” mode to exercise the supervisor lifecycle over the session channel.
internal/dockerdeploy/controlled_session_workload_pty.go	Tracks container ID and adds `Started()`/`Cleanup()` for supervised teardown correctness.
internal/dockerdeploy/controlled_session_workload_pty_test.go	Updates PTY adapter tests for container-ID operations and cleanup idempotence.
internal/dockerdeploy/controlled_session_supervisor.go	New supervisor that owns the controlled-session lifecycle from prepare through delivery-tail cleanup.
internal/dockerdeploy/controlled_session_supervisor_test.go	New unit tests covering normal lifecycle, cancellation, runtime-loss, and deadlines.
internal/dockerdeploy/controlled_session_supervisor_integration_test.go	New Docker integration test validating end-to-end supervised behavior and cleanup.
internal/dockerdeploy/controlled_session_controller.go	Reuses shared Docker container-ID parsing helper.
internal/dockerdeploy/controlled_session_controller_test.go	Updates container-ID parsing test to the renamed shared helper.
internal/controlledsession/lifecycle.go	Adds startup-failure modeling for “pending workload output finalization” cases.
internal/controlledsession/lifecycle_test.go	Adds coverage for startup failure waiting on partially-started workload output finalization.
docs/CONTROLLED_SESSION_DESIGN.md	Updates design documentation to reflect the implemented host supervisor.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+func (process *fakeControlledSessionProcessV1) ForceStop(context.Context) error {
+	process.forceStopped = true
+	return nil
+}


chatgpt-codex-connector · 2026-08-08T21:53:28Z

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c8b257055e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-08T21:56:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88709615e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-08T22:22:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d41e0f3203

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-08T22:35:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6416ae1db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-08T22:47:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 215c80816e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-08T23:00:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01b3781416

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-09T05:57:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9a9982870

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-09T06:05:38Z

@codex review

chatgpt-codex-connector · 2026-08-09T06:11:11Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: d05ab95d56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry changed the base branch from main to pr29 August 8, 2026 21:46

omry marked this pull request as ready for review August 8, 2026 21:47

Copilot AI lite review requested due to automatic review settings August 8, 2026 21:47

Copilot started reviewing on behalf of omry August 8, 2026 21:47 View session

Copilot AI reviewed Aug 8, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_supervisor_test.go

Comment on lines +489 to +492

func (process *fakeControlledSessionProcessV1) ForceStop(context.Context) error {

process.forceStopped = true

return nil

}

omry force-pushed the pr30 branch from c8b2570 to 8870961 Compare August 8, 2026 21:56

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_supervisor.go

omry force-pushed the pr30 branch from 8870961 to d41e0f3 Compare August 8, 2026 22:21

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_supervisor.go

omry force-pushed the pr30 branch from d41e0f3 to e6416ae Compare August 8, 2026 22:35

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_supervisor.go

omry force-pushed the pr30 branch from e6416ae to 215c808 Compare August 8, 2026 22:46

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_supervisor.go

Comment thread internal/controlledsession/session_io.go Outdated

omry force-pushed the pr30 branch from 215c808 to 01b3781 Compare August 8, 2026 23:00

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_supervisor.go

omry force-pushed the pr30 branch from 01b3781 to f9a9982 Compare August 9, 2026 05:57

chatgpt-codex-connector Bot reviewed Aug 9, 2026

View reviewed changes

Comment thread internal/dockerdeploy/testdata/session_channel_helper/main.go Outdated

omry force-pushed the pr30 branch from f9a9982 to d05ab95 Compare August 9, 2026 06:05

omry added the approved PR reviewed and approved label Aug 9, 2026

omry mentioned this pull request Aug 9, 2026

Prove controlled-session lifecycle in Docker #31

Open

omry force-pushed the pr30 branch from 6fb6374 to 82d8a33 Compare August 9, 2026 22:19

omry force-pushed the pr30 branch 2 times, most recently from a47e386 to f3ab504 Compare August 9, 2026 22:48

omry force-pushed the pr30 branch from f3ab504 to b99b739 Compare August 9, 2026 22:59

omry force-pushed the pr30 branch from b99b739 to 2296fe3 Compare August 9, 2026 23:11

omry force-pushed the pr30 branch 2 times, most recently from 2aacca6 to 938e7dd Compare August 9, 2026 23:34

omry force-pushed the pr30 branch from 938e7dd to cacb307 Compare August 9, 2026 23:44

omry force-pushed the pr30 branch from cacb307 to 1a683df Compare August 9, 2026 23:58

omry force-pushed the pr30 branch from 1a683df to 23034d8 Compare August 10, 2026 00:12

This was referenced Aug 10, 2026

Fail closed when session watchdog exits #35

Open

Persist controlled-session crash receipts #36

Open

Supervise controlled-session lifecycle

947c9b7

omry force-pushed the pr30 branch from 23034d8 to 947c9b7 Compare August 10, 2026 10:42

This was referenced Aug 10, 2026

Retry controlled-session watchdog cleanup #37

Open

Plan controlled-session networking #38

Open

Add controlled-session network adapter #39

Open

Persist controlled-session network ownership #40

Open

Conversation

omry commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omry commented Aug 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

chatgpt-codex-connector Bot commented Aug 8, 2026

Uh oh!

omry commented Aug 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

omry commented Aug 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

omry commented Aug 8, 2026 •

edited

Loading